Skip to content

Remove Redundant Variables from Encoder and Decoder #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 1, 2023
Merged

Remove Redundant Variables from Encoder and Decoder #5569

merged 22 commits into from
Nov 1, 2023

Conversation

@hisushanta
Copy link
Contributor

@hisushanta hisushanta commented Oct 29, 2023 •
edited
Loading

I removed the dummy variable defined in both the encoder and decoder.

  • First Encoder part:

Replace x with sample

  • Second Decoder part:

Replace z with sample

Before submitting

hisushanta and others added 21 commits October 5, 2023 06:34
@hisushanta
I added a new doc string to the class. This is more flexible to under…
8425cd4 
…standing other developers what are doing and where it's using.
@hisushanta
Merge branch 'main' into doc_string
8a0e77d
@hisushanta
Merge branch 'main' into doc_string
cf3a816
@hisushanta
Merge branch 'main' into doc_string
a0cd96f
@hisushanta @sayakpaul
Update src/diffusers/models/unet_2d_blocks.py
746a8e8 
This changes suggest by maintener.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@hisushanta @sayakpaul
Update src/diffusers/models/unet_2d_blocks.py
6e56886 
Add suggested text

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@hisushanta
Update unet_2d_blocks.py
627fd9f 
I changed the Parameter to Args text.
@hisushanta
Update unet_2d_blocks.py
ae4f7f2 
proper indentation set in this file.
@hisushanta
Update unet_2d_blocks.py
f0bea43 
a little bit of change in the act_fun argument line.
@hisushanta
Merge branch 'main' into doc_string
872a4a5
@hisushanta
I run the black command to reformat style in the code
3546f6d
@hisushanta
Merge branch 'main' into doc_string
12534f4
@hisushanta
Merge branch 'main' into doc_string
48afb4b
@hisushanta
Merge pull request #1 from hi-sushanta/doc_string
0bb06b6 
Doc string
@hisushanta
Update unet_2d_blocks.py
01a9fc9 
similar doc-string add to have in the original diffusion repository.
@hisushanta
Merge branch 'huggingface:main' into main
04e6efb
@hisushanta
Merge branch 'huggingface:main' into main
d695c4a
@hisushanta
Merge branch 'huggingface:main' into main
27d8002
@hisushanta
Merge branch 'huggingface:main' into main
55001e3
@hisushanta
I removed the dummy variable defined in both the encoder and decoder.
57d534a
@hisushanta
Now, I run black package to reformat my file
1fdcd40
@DN6 DN6 self-requested a review October 31, 2023 06:05
DN6
DN6 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽

@hisushanta
Copy link
Contributor Author

hisushanta commented Oct 31, 2023

Thank you🤗 @DN6

@patrickvonplaten patrickvonplaten merged commit 29cf163 into huggingface:main Nov 1, 2023
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
@hisushanta @sayakpaul
@DN6 @kashif
Remove Redundant Variables from Encoder and Decoder (huggingface#5569)
f23e44e 
* I added a new doc string to the class. This is more flexible to understanding other developers what are doing and where it's using.

* Update src/diffusers/models/unet_2d_blocks.py

This changes suggest by maintener.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

* Update src/diffusers/models/unet_2d_blocks.py

Add suggested text

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

* Update unet_2d_blocks.py

I changed the Parameter to Args text.

* Update unet_2d_blocks.py

proper indentation set in this file.

* Update unet_2d_blocks.py

a little bit of change in the act_fun argument line.

* I run the black command to reformat style in the code

* Update unet_2d_blocks.py

similar doc-string add to have in the original diffusion repository.

* I removed the dummy variable defined in both the encoder and decoder.

* Now, I run black package to reformat my file

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@hisushanta @sayakpaul @DN6
Remove Redundant Variables from Encoder and Decoder (huggingface#5569)
ffef55d 
* I added a new doc string to the class. This is more flexible to understanding other developers what are doing and where it's using.

* Update src/diffusers/models/unet_2d_blocks.py

This changes suggest by maintener.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

* Update src/diffusers/models/unet_2d_blocks.py

Add suggested text

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

* Update unet_2d_blocks.py

I changed the Parameter to Args text.

* Update unet_2d_blocks.py

proper indentation set in this file.

* Update unet_2d_blocks.py

a little bit of change in the act_fun argument line.

* I run the black command to reformat style in the code

* Update unet_2d_blocks.py

similar doc-string add to have in the original diffusion repository.

* I removed the dummy variable defined in both the encoder and decoder.

* Now, I run black package to reformat my file

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@hisushanta @sayakpaul @DN6
Remove Redundant Variables from Encoder and Decoder (huggingface#5569)
61b6743 
* I added a new doc string to the class. This is more flexible to understanding other developers what are doing and where it's using.

* Update src/diffusers/models/unet_2d_blocks.py

This changes suggest by maintener.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

* Update src/diffusers/models/unet_2d_blocks.py

Add suggested text

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

* Update unet_2d_blocks.py

I changed the Parameter to Args text.

* Update unet_2d_blocks.py

proper indentation set in this file.

* Update unet_2d_blocks.py

a little bit of change in the act_fun argument line.

* I run the black command to reformat style in the code

* Update unet_2d_blocks.py

similar doc-string add to have in the original diffusion repository.

* I removed the dummy variable defined in both the encoder and decoder.

* Now, I run black package to reformat my file

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6 DN6 DN6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hisushanta @DN6 @patrickvonplaten