Skip to content

Conversation

@tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Nov 14, 2023

What does this PR do?

Remove .to('cuda') before cpu_offload, and trim trailing whitespace. #1934 also applies to enable_model_cpu_offload(). The GPU vRAM usage difference ranges from several hundred MiBs to several GiBs.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu, @yiyixuxu

@tolgacangoz tolgacangoz marked this pull request as ready for review November 14, 2023 16:57
@tolgacangoz tolgacangoz changed the title Remove .to('cuda') before cpu_offload, trim trailing whitespaces [Docs] Remove .to('cuda') before enable_model_cpu_offload() Nov 14, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 14, 2023

The documentation is not available anymore as the PR was closed or merged.

@tolgacangoz tolgacangoz changed the title [Docs] Remove .to('cuda') before enable_model_cpu_offload() [Docs] Remove .to('cuda') before .enable_model_cpu_offload() Nov 14, 2023
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@stevhliu stevhliu merged commit 51fd3dd into huggingface:main Nov 15, 2023
@tolgacangoz tolgacangoz deleted the fix-typos-cpu_offload branch November 30, 2023 07:21
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…uggingface#5795)

Remove .to('cuda') before cpu_offload, trim trailing whitespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants