[Training examples] Follow up of #6306 #6346
Merged
+29
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Thanks Sayak ! Can you also replace this line: https://github.com/huggingface/diffusers/blob/main/examples/consistency_distillation/train_lcm_distill_lora_sdxl.py#L1187 with accelerator.unwrap_model(unet).disable_adapters() in order to fix #6351 at the same time? 🙏
Member
Author
|
@younesbelkada done. Would appreciate another thorough review. |
younesbelkada
approved these changes
Dec 27, 2023
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Thanks very much Sayak!
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 29, 2023
* add to dreambooth lora. * add: t2i lora. * add: sdxl t2i lora. * style * lcm lora sdxl. * unwrap * fix: enable_adapters().
antoine-scenario
pushed a commit
to antoine-scenario/diffusers
that referenced
this pull request
Jan 2, 2024
* add to dreambooth lora. * add: t2i lora. * add: sdxl t2i lora. * style * lcm lora sdxl. * unwrap * fix: enable_adapters().
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* add to dreambooth lora. * add: t2i lora. * add: sdxl t2i lora. * style * lcm lora sdxl. * unwrap * fix: enable_adapters().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up of #6306.
Fixes #6351