[Refactor] save_model_card function in text_to_image examples
#7051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolgacangoz
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
tolgacangoz
changed the title
Refactor] save_model_card function in text_to_image examples
sayakpaul
reviewed
Feb 23, 2024
sayakpaul
reviewed
Feb 23, 2024
sayakpaul
reviewed
Feb 23, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
I have left some comments. I don't think these changes are really necessary.
tolgacangoz
commented
Feb 23, 2024
tolgacangoz
commented
Feb 23, 2024
sayakpaul
reviewed
Feb 23, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
The images none check is fine. Let's keep it.
sayakpaul
approved these changes
Feb 23, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks for beating it with me!
Contributor
Author
|
Thanks for reviewing and giving feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the save_model_card function to handle the parameters of the
imagesandrepo_folder. It ensures that the function can handle both cases when images are provided and when not.len(images)was improper for theimages' default None value. Also, None was improper as a default foros.path.joinin terms ofrepo_folder.@sayakpaul