Skip to content

Conversation

@sayakpaul
Copy link
Member

What does this PR do?

This PR adds another call to the log_validation() function after the serialization of the trained ControlNet checkpoint. This helps to validate if the training was effective and catch issues like #7080.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the added section in the readme -
I am not sure if the rest of the change is needed here since there isn't any actual bug in #7080; they just did not resize the control_image, and I think it complicates codes quite a bit

But I'm ok with it if you think it is better this way

@sayakpaul
Copy link
Member Author

I think it complicates codes quite a bit

Why do you think the code becomes more complicated? The change is also in line with what we do in other training scripts, i.e., run a final validation inference with the saved checkpoint.

@yiyixuxu
Copy link
Collaborator

Why do you think the code becomes more complicated? The change is also in line with what we do in other training scripts, i.e., run a final validation inference with the saved checkpoint.

ok!

@sayakpaul sayakpaul merged commit 7081a25 into main Feb 27, 2024
@sayakpaul sayakpaul deleted the controlnet-example-inferenc branch February 27, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants