Skip to content

Conversation

@stevhliu
Copy link
Member

@stevhliu stevhliu commented Mar 5, 2024

Continuation of #7016 with some light edits to the ip_adapter_image_embeds and masking sections, and adds IPAdapterMaskProcessor.preprocess to the API docs.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu requested review from sayakpaul and yiyixuxu March 5, 2024 18:20
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

</div>
</div>

When there is more than one input IP-Adapter image, load them as a list to ensure each image is assigned to a different IP-Adapter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiyixuxu just to confirm can we assign multiple images to a single IP Adapter? If so, I think this line needs to rephrased.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Left a couple of comments.

@stevhliu stevhliu requested a review from sayakpaul March 7, 2024 22:13
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Steven!

@stevhliu stevhliu merged commit 1f22c98 into huggingface:main Mar 8, 2024
@stevhliu stevhliu deleted the ip-adapters branch March 8, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants