update get_order_list if statement #7309
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyixuxu
reviewed
Mar 14, 2024
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
hey thanks for the PR!
I left a question
| orders = [1] * steps | ||
| else: | ||
| if order == 3: | ||
| if order >= 3: |
Collaborator
There was a problem hiding this comment.
why is this change needed here?
if order > 3, we will already throw an error so it is not possible to have order > 3 here, no?
Contributor
Author
There was a problem hiding this comment.
Agree. Leaving conversation open for maintainers if needed but this has been actioned ⚡
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5705 by adding additional checks on number of
orderparameters according to @vladmandic recommendation here.Additionally follows directive from @patrickvonplaten here and raises
valueErroriforder > 3.