Skip to content

fix(sd3): fix deletion of text_encoders etc #8951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiyixuxu merged 3 commits into from
Aug 19, 2024
+1 −1
Merged

fix(sd3): fix deletion of text_encoders etc #8951

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e67a531
fix(sd3): fix deletion of text_encoders etc
townwish4git Jul 24, 2024
804d4c1
Merge branch 'main' into sd3_lora_fix
sayakpaul Jul 24, 2024
ecd08dc
Merge branch 'main' into sd3_lora_fix
yiyixuxu Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/dreambooth/train_dreambooth_lora_sd3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,7 @@ def compute_text_embeddings(prompt, text_encoders, tokenizers):
)

# Clear the memory here
if not args.train_text_encoder and train_dataset.custom_instance_prompts:
if not args.train_text_encoder and not train_dataset.custom_instance_prompts:
del tokenizers, text_encoders
# Explicitly delete the objects as well, otherwise only the lists are deleted and the original references remain, preventing garbage collection
del text_encoder_one, text_encoder_two, text_encoder_three
Expand Down