Skip to content

Conversation

@swapdewalkar
Copy link

What does this PR do?

Fixes #9027

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Aug 5, 2024

I think it's easier to change the doc string to "tokens" instead of changing the argument (might beak for some users), no?

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@a-r-r-o-w a-r-r-o-w removed the stale Issues that haven't received updates label Oct 29, 2024
@a-r-r-o-w
Copy link
Contributor

Closing in favor of #9940

@a-r-r-o-w a-r-r-o-w closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consistency in argument names

3 participants