-
Notifications
You must be signed in to change notification settings - Fork 6.5k
🚨 feat: add non-breaking support to serialize metadata in loras. #9143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+368
−55
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1819000
feat: add non-breaking support to serialize metadata in loras.
sayakpaul 2b9f77e
fix flux test
sayakpaul fb9e86d
Apply suggestions from code review
sayakpaul 79aff1d
fix lora_alpha
sayakpaul 733e1d9
documentation
sayakpaul 167557b
fix-copues
sayakpaul 6bbf629
style
sayakpaul 225634e
Merge branch 'main' into feat-config-metadata
sayakpaul 48768b6
style
sayakpaul 632bf78
fix-copies
sayakpaul 91cfffc
check,
sayakpaul 6fb5987
utilize fix-copies better.
sayakpaul 1852c3f
style
sayakpaul 712a110
style
sayakpaul f7d30de
alpha_pattern and rank+pattern
sayakpaul d79c0d5
Merge branch 'main' into feat-config-metadata
sayakpaul e7808e4
fix
sayakpaul 178a459
add: comment.
sayakpaul 9d411fd
Merge branch 'main' into feat-config-metadata
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we have any way or desire to warn users loading a lora from a pth file that we can't scale it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently error out when trying to save metadata to a pth file (or more generally, when
use_safetensorsis False).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good! i never use them. but i was concerned for others.