refactor 3d rope for cogvideox #9269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyixuxu
commented
Aug 25, 2024
| Returns: | ||
| `torch.Tensor`: positional embedding with shape `(temporal_size * grid_size[0] * grid_size[1], embed_dim/2)`. | ||
| """ | ||
| if use_real is not True: |
Collaborator
Author
There was a problem hiding this comment.
I removed the support for use_real for now since it is not used in cogvideox (and the logic is somewhat different from what I would have expected based on our 2d rope implementation - let's add that support in the future when it is needed)
a-r-r-o-w
reviewed
Aug 25, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
approved these changes
Aug 25, 2024
Contributor
a-r-r-o-w
left a comment
a-r-r-o-w
left a comment
There was a problem hiding this comment.
Thanks, looks great! I've verified that the outputs before and after this PR are the same
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
* refactor 3d rope * repeat -> expand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of cogvideox refactor
related #9263
a unit test here https://colab.research.google.com/drive/1qbFPAblW8wZvLoFCqV-sXzEZQLgujF2k?usp=sharing
cc @a-r-r-o-w