Skip to content

Revert timeout workarounds from #725, keep chunk length increases#732

Merged
mishig25 merged 1 commit intomainfrom
revert_unnede_change
Jan 26, 2026
Merged

Revert timeout workarounds from #725, keep chunk length increases#732
mishig25 merged 1 commit intomainfrom
revert_unnede_change

Conversation

@mishig25
Copy link
Contributor

@mishig25 mishig25 commented Jan 26, 2026

Summary

  • Reverts the processing logic changes from commit 894c424 (Fix GitHub Action timeout during Meili indexation #725) that added 1-hour delays between libraries and removed @wait_for_task_completion decorator
  • Restores the original batch processing approach where all embeddings are generated and uploaded together
  • Keeps the chunk length increases (2000→4000 for CHUNK_LEN_CHARS, 1000→2000 for excerpt-length) which help reduce total embedding count

Test plan

  • Verify the embeddings workflow runs successfully without the 1-hour delays
  • Confirm the @wait_for_task_completion decorator properly waits for Meilisearch tasks

Reverts the processing logic changes from commit 894c424 that:
- Removed @wait_for_task_completion decorator from add_embeddings_to_db
- Changed to process one library at a time with 1-hour delays

Keeps the chunk length increases (2000->4000 and 1000->2000) which help
reduce the total number of embeddings.
@mishig25 mishig25 merged commit 00edadd into main Jan 26, 2026
4 checks passed
@mishig25 mishig25 deleted the revert_unnede_change branch January 26, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant