fix(ci): sync to bucket before zip-push to preserve extracted files#782
Merged
Conversation
The 'Push to dataset (legacy)' step replaces the build output with a
zip ('main.zip') and '_versions.yml', so the subsequent 'Sync to bucket'
step only sees those 2 files and the extracted HTML/MD never reaches
hf-doc-build/doc. As a result, the bucket-backed doc deployment has
been frozen on stale content: its 'main/' directory is not refreshed on
each merge.
Fix: run the sync before the zip-push so the bucket receives the full
extracted tree (./<package>/main/**). Also split the notebooks handling
into its own step (previously nested inside 'Sync to bucket').
mishig25
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync to bucketstep beforePush to dataset (legacy)so the bucket receives the full extracted tree (./<package>/main/**), not justmain.zipand_versions.yml.Sync to bucket).Why
The
doc-builder pushstep replaces the build output with a zip (main.zip) and_versions.yml, so the subsequenthf synconly sees those 2 files. As a result, for all doc packages now served fromhf-doc-build/docvia the bucket-backed deploy (moon-landingprod-hub-doc), themain/directory in the bucket has not been refreshed on merges since the migration.Concretely: huggingface/hub-docs#2400 merged at 2026-04-17 11:55 UTC, workflow ran successfully, the bucket sync step reported
Uploads: 2(the zip + versions), but the individual.html/.mdunderhub/main/en/were never uploaded. Prod still serves the pre-migration content.By running the bucket sync first, the full extracted tree is uploaded, and the legacy zip push still runs afterwards so the Dataset-based rollback path stays intact.