Move ModelInfo up and rename as RepoInfo.
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Author: Luc Georges<luc@huggingface.co>
Narsil
force-pushed
the
move_up_model_info
branch
from
db0e4ea to
fdf7316
Compare
McPatate
reviewed
Jul 31, 2023
| model_info, | ||
| ModelInfo { | ||
| RepoInfo { | ||
| sha: "2dd3f79917d431e9af1c81bfa96a575741774077".to_string(), |
Member
There was a problem hiding this comment.
This will eventually break when refs/convert/parquet is updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just using good idea from #2 while ignoring
is_mainwhich I find a bit niche for now).