Skip to content

Conversation

@Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Dec 12, 2024

TODO:

https://moon-ci-docs.huggingface.co/docs/hub/pr_1526/en/dduf

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Wauplin and others added 2 commits December 12, 2024 14:29
Co-authored-by: Célina <hanouticelina@gmail.com>
Wauplin and others added 4 commits December 12, 2024 14:38
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Wauplin and others added 3 commits December 12, 2024 15:06
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: vb <vaibhavs10@gmail.com>
Co-authored-by: vb <vaibhavs10@gmail.com>
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice! 👏

docs/hub/dduf.md Outdated

## Overview

DDUF (**D**DUF’s **D**iffusion **U**nified **F**ormat) is a file format designed to make storing, distributing, and using diffusion models much easier. Built on the ZIP file format, DDUF offers a standardized, efficient, and flexible way to package all parts of a diffusion model into a single, easy-to-manage file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffusion Data Unified Format maybe? Also fine with it as is 😄

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very detailed! Steven has already taken care of most of the stuff. My comments are quite minor.

Comment on lines +143 to +147
ZIP provides several advantages:
- Universally supported file format
- No additional dependencies for reading
- Built-in file indexing
- Wide language support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-c should there be any points pertaining to the connection between using ZIP and how that benefits Xet backend?

@Wauplin Wauplin changed the title Start DDUF documentation DDUF documentation Dec 13, 2024
@Wauplin Wauplin requested a review from stevhliu December 13, 2024 09:59
@Wauplin
Copy link
Contributor Author

Wauplin commented Dec 13, 2024

Many thanks for the review! Very useful feedback ❤️ I've not addressed all the comments and added a diffusers example. Close to getting an approval? 🤗

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to add a Who's using DDUF section which will be one of the most important section of this doc (#community-driven)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, there is a start at the very bottom of the page (could be moved to its own section)

@Wauplin
Copy link
Contributor Author

Wauplin commented Dec 13, 2024

Will merge this once huggingface_hub / diffusers have been released :)

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs ! LGTM !

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets gooo


### Which frameworks/apps support DDUFs?

- [Diffusers](https://github.com/huggingface/diffusers)
Copy link
Member

@Vaibhavs10 Vaibhavs10 Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we might have Eric's diffuse-rs (candle-based) come in by monday too. So we'll have two supported frameworsk on day-0, but we can open a seperate pr for that

@sayakpaul
Copy link
Member

@Wauplin should this be merged now?

@julien-c
Copy link
Member

julien-c commented Jan 1, 2025

@sayakpaul Yes, let's go!

@julien-c julien-c merged commit 6aff20e into main Jan 1, 2025
2 checks passed
@julien-c julien-c deleted the dduf branch January 1, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants