Skip to content

Add links to code of conduct and content guideline#283

Merged
osanseviero merged 1 commit into
mainfrom
code-of-conduct
Aug 18, 2022
Merged

Add links to code of conduct and content guideline#283
osanseviero merged 1 commit into
mainfrom
code-of-conduct

Conversation

@NimaBoscarino
Copy link
Copy Markdown
Contributor

@NimaBoscarino NimaBoscarino commented Aug 17, 2022

This PR adds links to the code of conduct and the content guideline from the main hub-docs page.

@NimaBoscarino NimaBoscarino requested a review from Pierrci August 17, 2022 00:00
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Aug 17, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

Pierrci
Pierrci approved these changes Aug 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Pierrci Pierrci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @NimaBoscarino

@osanseviero osanseviero merged commit 8b6da33 into main Aug 18, 2022
@osanseviero osanseviero deleted the code-of-conduct branch August 18, 2022 16:17
@julien-c
Copy link
Copy Markdown
Member

julien-c commented Aug 22, 2022

shouldn't they also be listed in the left sidebar here?
image

@NimaBoscarino
Copy link
Copy Markdown
Contributor Author

NimaBoscarino commented Aug 23, 2022

As far as I know, the left sidebar lists markdown pages and doesn't link to other URLs. I embedded the code of conduct and content guideline as URLs, since I didn't think that they warranted their own full page in the hub-docs. But if we want that, I can totally make a full page for it!

@osanseviero
Copy link
Copy Markdown
Contributor

osanseviero commented Aug 24, 2022

cc @mishig25. Is it possible to list external URLs in the sidebar in the docs?

@julien-c
Copy link
Copy Markdown
Member

julien-c commented Aug 24, 2022

As far as I know, the left sidebar lists markdown pages and doesn't link to other URLs. I embedded the code of conduct and content guideline as URLs, since I didn't think that they warranted their own full page in the hub-docs. But if we want that, I can totally make a full page for it!

oh yeah you're right I missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierrci Pierrci Pierrci approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NimaBoscarino @HuggingFaceDocBuilderDev @julien-c @osanseviero @Pierrci