Skip to content

Conversation

@oguzakif
Copy link
Contributor

@oguzakif oguzakif commented Oct 6, 2022

Summary

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributions!!! ❤️ I left two comments, otherwise looks very good to me 🙂

The pages serve as the first stop people who would like to know about a task and maybe build a quick PoC for their business case on it so it's important to stay a bit more general on the models and the datasets side 🙂

@oguzakif oguzakif requested a review from merveenoyan October 7, 2022 14:20
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, @osanseviero can you quickly check? I don't think we have a canonical dataset for the task BTW (not very sure)

I found two image-to-text ones which can be used for the task imo, WDYT:

https://huggingface.co/datasets/red_caps
https://huggingface.co/datasets/conceptual_captions

I'll be happy to merge after the key-space and indent errors are fixed 🙂

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thanks! 🔥

As @merveenoyan mentioned, a couple of datasets could be a good fit here. Apart from the 2 already great ones Merve shared, the ones from LAION are quite used right now https://huggingface.co/laion (e.g. https://huggingface.co/datasets/laion/laion2B-en-aesthetic)

oguzakif and others added 2 commits October 10, 2022 22:33
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge, but can you install eslint and do CTRL+S on data.ts so it's formatted? There are indentation and key-value space related issues. Thanks a lot for working on this! 🙌🏻 Also you can remove about.md as it's empty.

@oguzakif
Copy link
Contributor Author

I'm happy to merge, but can you install eslint and do CTRL+S on data.ts so it's formatted? There are indentation and key-value space related issues. Thanks a lot for working on this! 🙌🏻 Also you can remove about.md as it's empty.

I have fixed the indent and key-value space issues but i couldnt find the eslint config file. Could you give the configuration file you have used for future uses ?

@merveenoyan merveenoyan merged commit f19a8f8 into huggingface:main Oct 13, 2022
@merveenoyan
Copy link
Contributor

I will format it myself, thanks a lot for the contribution! What is your hugging face Hub handle so I can add your name to the doc later? 🙂 @oguzakif

@oguzakif
Copy link
Contributor Author

Did you mean my hugging face username ? https://huggingface.co/oguzakif
I have changed the attributes in the below:

  • Most used models
  • most used datasets
  • Summary is added
    @merveenoyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants