Conversation
|
You will also need to update in a couple of other places https://github.com/search?q=repo%3Ahuggingface%2Fhub-docs+TEXT-to-speech+language%3ATypeScript&type=code&l=TypeScript |
|
I think I added it to all the relevant ones. Do you mind giving it a look again please @osanseviero ? |
osanseviero
left a comment
There was a problem hiding this comment.
Thank you! Please check that you have similar set of files as in https://github.com/search?q=repo%3Ahuggingface%2Fhub-docs+TEXT-to-speech+language%3ATypeScript&type=code&l=TypeScript
- You also need to add it to tasksData (can lead to an undefined task page for now (or same as TTS?) - in any case, if not, let's open an issue for a follow-up task page
- Need to specify which libraries (and here) support this task
osanseviero
left a comment
There was a problem hiding this comment.
Awesome, things are looking good! You will also need to
- Add an icon (similar to https://github.com/huggingface/hub-docs/blob/main/js/src/lib/components/Icons/IconTextToSpeech.svelte ) and specify it in https://github.com/huggingface/hub-docs/blob/main/js/src/lib/components/PipelineIcon/PipelineIcon.svelte#L27 (I suggest to check https://carbondesignsystem.com/ for icons)
- You might also want to enable the widget, which involves modifying https://github.com/huggingface/hub-docs/blob/main/js/src/lib/components/InferenceWidget/InferenceWidget.svelte (most likely you can re-use
TextToSpeechWidget)
You can preview how this would look like in GitHub Codespaces as specified in https://github.com/huggingface/moon-landing#codespace
|
Noice. Going to to test this now! |
|
Weird! I keep getting permission denied on codespace for anything I do. Is this the same for you too @osanseviero ? |
|
Hey @mishig25 After your suggestions, I tried running Send help! - welp! |
|
Was TextToAudio widget was created in this PR ?
npm run format:all was the one Line 14 in b1a591d |
|
Hey @mishig25 - I just copied InferenceTextToSpeech widget over to text-to-audio. Let me know if this is okay for you? |
|
I think we should reuse |
|
Btw, is the task already supported in api-inference? Is there a model or curl script to test on ? |
|
Hey! @mishig25 - Sorry for the delayed response, Since the pipeline_tag Do note that this is embarrassingly slow - will work on fixing that separately. @osanseviero - I was thinking of making a follow-up PR to update the Icon for TTM, that's why I created those files. I think it'd be good to distinguish the two. However, if you feel strongly about this then I can revert the change. lmk. I'll treat this as priority today, would be nice to get this merged soon. |
|
Note: that |
osanseviero
left a comment
There was a problem hiding this comment.
Ok from my side to follow-up with the icon, but as mentioned before, we should reuse the widget, no need to implement a new one
|
@osanseviero - Removed all the custom Is there anything else left for this to be good to merge? @mishig25 @osanseviero |
|
Both the checks have passed! 🤗 |
osanseviero
left a comment
There was a problem hiding this comment.
LGTM to merge if the TTA Inference API is working already
|
Good to merge, then? For testing the inference API, feel free to head over to this URL: https://huggingface.co/reach-vb/musicgen-small |
| "fill-mask": IconFillMask, | ||
| "sentence-similarity": IconSentenceSimilarity, | ||
| "text-to-speech": IconTextToSpeech, | ||
| "text-to-audio": IconTextToAudio, |
There was a problem hiding this comment.
if it is exact same icon as IconTextToSpeech, why not just use IconTextToSpeech ?
There was a problem hiding this comment.
Good call: I fixed it in the latest commit.
|
It seems stuck in loading or internal server errors though |
|
@osanseviero -> The model is pretty much unusable on CPU (it takes an insane amount of time to generate). I tested it from The plan is to enable these for GPU run-time once the pipeline is merged. |

No description provided.