MLX snippet updates #1397
Merged
MLX snippet updates #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c and
ngxson
as code owners
pcuenca
commented
Apr 29, 2025
| export const mlxvlm = (model: ModelData): string[] => [ | ||
| `pip install --upgrade mlx-vlm | ||
| mlx_vlm.generate --model ${model.id} \\ |
Member
Author
There was a problem hiding this comment.
Not sure if we should use one \, two, three, or what.
pcuenca
commented
Apr 29, 2025
Comment on lines
+1301
to
+1305
| const mlxlm = (model: ModelData): string[] => [ | ||
| `pip install --upgrade mlx-lm | ||
| mlx_lm.generate --model ${model.id} --prompt "Hello"`, | ||
| ]; |
Member
Author
There was a problem hiding this comment.
An alternative is to use a "real" snippet like the ones in the model cards, but I think a CLI one-liner is enough here.
Vaibhavs10
approved these changes
May 5, 2025
Contributor
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
NICEEE! anything blocking the merge? @pcuenca
Member
Author
|
@Vaibhavs10 Nope, I was just waiting in case you or Victor would provide any feedback. Also, I was anxious about the failing tests, even if they looked unrelated 😂. I think I escaped the bash line continuation backslash characters properly, but we can find out in production! |
Collaborator
|
LGTM (sry for late reply) |
Member
Author
|
Nice, thank you @gary149! Waiting for it to be deployed to check VLMs too! |
Deep-unlearning
pushed a commit
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t @gary149