Remove mistral-common from modeling libraries #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
SBrandeis,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
Member
maybe you can add it in the comment of countDownloads in model-libraries.ts for public documentation |
Contributor
Author
|
good call, added in 7098d90 |
julien-c
approved these changes
Jul 24, 2025
| `, | ||
| ]; | ||
|
|
||
| export const mistral_common = (model: ModelData): string[] => [ |
There was a problem hiding this comment.
Hmm is there no way for us to have control over what is displayed on: Use this model
?
I think we would like to always show vLLM first here
Contributor
Author
There was a problem hiding this comment.
order of Libraries > Notebooks > Local Apps is not configurable no
Contributor
Author
|
(merging this one now to unblock moon-landing deploy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1641 and especially #1641 (comment) (cc @LysandreJik @juliendenize).
The plan is:
in model cards metadata
mistral-commonfrom registered libraries as it's not a modelling library but more of a set of utilsconfig.jsonANDparams.jsonfor those repos (will be handled server-side, see private PR)mistral-commonrepos