Skip to content

Remove mistral-common from modeling libraries #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Remove mistral-common from modeling libraries #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6dabd0
Remove mistral-common from modeling libraries
Wauplin Jul 24, 2025
7098d90
document params.json
Wauplin Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions packages/tasks/src/model-libraries-snippets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2024,23 +2024,4 @@ torchaudio.save("sample.wav", audio, model.autoencoder.sampling_rate)
`,
];

export const mistral_common = (model: ModelData): string[] => [
Copy link

@patrickvonplaten patrickvonplaten Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm is there no way for us to have control over what is displayed on: Use this model

Screenshot 2025-07-24 at 18 17 08

?

I think we would like to always show vLLM first here

Copy link
Contributor Author

@Wauplin Wauplin Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order of Libraries > Notebooks > Local Apps is not configurable no

`# We recommend to use vLLM to serve Mistral AI models.
pip install vllm

# Make sure to have installed the latest version of mistral-common.
pip install --upgrade mistral-common[image,audio]

# Serve the model with an OpenAI-compatible API.
vllm serve ${model.id} --tokenizer_mode mistral --config_format mistral --load_format mistral --tool-call-parser mistral --enable-auto-tool-choice

# Query the model with curl in a separate terminal.
curl http://localhost:8000/v1/chat/completions \
-H "Content-Type: application/json" \
-d '{
"model": "${model.id}",
"messages": [{"role": "user", "content": "What is the capital of France?"}]
}'`,
];

//#endregion
10 changes: 1 addition & 9 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export interface LibraryUiElement {
* Elastic query used to count this library's model downloads
*
* By default, those files are counted:
* "config.json", "config.yaml", "hyperparams.yaml", "meta.yaml"
* "config.json", "config.yaml", "hyperparams.yaml", "params.json", "meta.yaml"
*/
countDownloads?: ElasticSearchQuery;
/**
Expand Down Expand Up @@ -631,14 +631,6 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
filter: false,
countDownloads: `path_extension:"ckpt"`,
},
mistral_common: {
prettyLabel: "mistral-common",
repoName: "mistral-common",
repoUrl: "https://github.com/mistralai/mistral-common",
docsUrl: "https://mistralai.github.io/mistral-common/",
snippets: snippets.mistral_common,
countDownloads: `path:"config.json" OR path:"params.json"`,
},
mitie: {
prettyLabel: "MITIE",
repoName: "MITIE",
Expand Down
Loading