Skip to content

xet chunker is created for each file instead of reused #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

xet chunker is created for each file instead of reused #1738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions packages/hub/src/utils/createXorbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ export async function* createXorbs(
let xorbId = 0;

await chunkModule.init();
const chunker = new chunkModule.Chunker(TARGET_CHUNK_SIZE);
const chunkCache = new ChunkCache();
let xorb = new CurrentXorbInfo();

Expand Down Expand Up @@ -147,8 +146,9 @@ export async function* createXorbs(

const remoteXorbHashes: string[] = [""]; // starts at index 1 (to simplify implem a bit)

try {
for await (const fileSource of fileSources) {
for await (const fileSource of fileSources) {
const chunker = new chunkModule.Chunker(TARGET_CHUNK_SIZE);
try {
xorb.fileSize[fileSource.path] = fileSource.content.size;

// Load dedup info for the first chunk of the file, if it's potentially modified by the splice
Expand Down Expand Up @@ -342,22 +342,22 @@ export async function* createXorbs(
dedupRatio,
representation: fileRepresentation,
});
} finally {
chunker.free();
// ^ is this really needed ?
}
}

if (xorb.offset > 0) {
yield xorb.event(chunkModule.compute_xorb_hash.bind(chunkModule));
}
if (xorb.offset > 0) {
yield xorb.event(chunkModule.compute_xorb_hash.bind(chunkModule));
}

for (const event of pendingFileEvents) {
event.representation = event.representation.map((rep) => ({
...rep,
xorbId: (rep.xorbId as number) >= 0 ? rep.xorbId : remoteXorbHashes[-rep.xorbId],
}));
yield event;
}
} finally {
chunker.free();
// ^ is this really needed ?
for (const event of pendingFileEvents) {
event.representation = event.representation.map((rep) => ({
...rep,
xorbId: (rep.xorbId as number) >= 0 ? rep.xorbId : remoteXorbHashes[-rep.xorbId],
}));
yield event;
}
}

Expand Down
Loading