Skip to content

Conversation

@neuhaus
Copy link
Contributor

@neuhaus neuhaus commented Oct 5, 2025

also used same whitespace for "Zen" throughout.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure about the Zen4, I like it spaced out Zen 4

cc: @pcuenca for his opinion too

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I think the usual way to refer to them is "Zen 5" with the space.

Could you please make those changes if possible @neuhaus 🙏 Thanks a lot for suggesting to make them consistent in the first place!

change spacing, add 1st gen Threadripper
@neuhaus
Copy link
Contributor Author

neuhaus commented Oct 6, 2025

Indeed, I think the usual way to refer to them is "Zen 5" with the space.

Could you please make those changes if possible @neuhaus 🙏 Thanks a lot for suggesting to make them consistent in the first place!

done!

@neuhaus neuhaus changed the title hardware.ts: Add Epyc Turin, Threadripper 9000+5000 hardware.ts: Add Epyc Turin, Threadripper 9000+5000+1000 Oct 6, 2025
@pcuenca
Copy link
Member

pcuenca commented Oct 6, 2025

Thanks, @neuhaus!

@pcuenca pcuenca merged commit 20e5e11 into huggingface:main Oct 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants