[Inference] Let's use lowercase left/right truncation direction parameter #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
SBrandeis,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
julien-c
approved these changes
Nov 13, 2025
SBrandeis
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First spotted by @alvarobartt on slack (internal).
The
FeatureExtractionInputTruncationDirectionparameter defined in the feature-extraction specs currently have capitalized valuesLeft/Right. This comes from TEI implementation from which we pulled the specs. Let's switch it to lowercase values for consistency with all other specs.In addition to this PR, we should:
left/right(not even sure we want backward compatibility on this) => @alvarobartt would you be able to handle this?huggingface_hub=> I can take care of this [Inference] Let's use lowercase left/right truncation direction parameter huggingface_hub#3548hub-docs=> will happen automaticallyI think it's fine to have breaking change for this. Moreover, specs / docs are there more for information but are rarely enforced (expect in TEI) so it shouldn't break anything client-side.