Add VideoX Fun library details #1875
Conversation
bubbliiiing
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Hi @bubbliiiing, thanks for your PR! I've left a comment regarding the download count rule which highly depends on the repo structure (we want to count all downloads but not double count them).
Apart from that, you need to add library_name: videox_fun in the model card metadata of the related models. I have opened this PR as an example: https://huggingface.co/alibaba-pai/CogVideoX-Fun-V1.5-5b-InP/discussions/2.
We will be able to merge this PR once https://huggingface.co/models?other=videox_fun gets populated with at least few models 🤗
| repoName: "VideoX Fun", | ||
| repoUrl: "https://github.com/aigc-apps/VideoX-Fun", | ||
| filter: false, | ||
| countDownloads: `path_extension:"safetensors"`, |
There was a problem hiding this comment.
This rule means that downloading any safetensors files from the repo will count as a download. This can be detrimental if multiple safetensors files are present in the repo as they would double-count them.
Looking at https://huggingface.co/alibaba-pai/CogVideoX-Fun-V1.5-5b-InP, it seems there are a few json config files in the repo. Would it be possible to count downloads on a specific one so we are sure we never double count?
There was a problem hiding this comment.
Hello, since videox-fun may contain many models—some with numerous files and others with only a few—how should I configure it?
There was a problem hiding this comment.
Do you have more examples of repos so I can have a look? Is there any pattern in the repos or not? How does VideoX Fun knows which files to load or not?
There was a problem hiding this comment.
Some libraries follow a format like that of Diffusers—similar to the one you provided—while others contain only a single .safetensors file.
https://huggingface.co/alibaba-pai/Z-Image-Turbo-Fun-Controlnet-Union
There was a problem hiding this comment.
Ok I've reviewed most repos in https://huggingface.co/alibaba-pai/models?search=fun and I think it's fine to keep path_extension:"safetensors" as it is done now 👍
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
All good!
As a last step before merging, can you add library_name: videox_fun to all models please? Similar to what I did here https://huggingface.co/alibaba-pai/CogVideoX-Fun-V1.5-5b-InP/discussions/2 but for the rest of them. Let me know once that's done and we should be good to merge 🤗
|
I've got it all done. |
2 participants
No description provided.