Skip to content

Conversation

@krrome
Copy link
Contributor

@krrome krrome commented Dec 4, 2025

Fixes #3594

…data

Signed-off-by: Roman Kayan BAZG <roman.kayan@bazg.admin.ch>
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting the issue and providing a fix @krrome . Could you also change the default value in hf_api.py module as well?

@krrome
Copy link
Contributor Author

krrome commented Dec 4, 2025

Sure, I assume you refer to https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/hf_api.py#L5246

The only question I have is if HF_HUB_DOWNLOAD_TIMEOUT is the correct env var or if HF_HUB_ETAG_TIMEOUT is a better fit?

@Wauplin
Copy link
Contributor

Wauplin commented Dec 4, 2025

Sure, I assume you refer to https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/hf_api.py#L5246

Yes exactly!

The only question I have is if HF_HUB_DOWNLOAD_TIMEOUT is the correct env var or if HF_HUB_ETAG_TIMEOUT is a better fit?

HF_HUB_ETAG_TIMEOUT is a better fit for that indeed 👍

Signed-off-by: Roman Kayan BAZG <roman.kayan@bazg.admin.ch>
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Wauplin Wauplin changed the title use constants.HF_HUB_DOWNLOAD_TIMEOUT as timeout for get_hf_file_meta… use constants.HF_HUB_ETAG_TIMEOUT as timeout for get_hf_file_meta… Dec 4, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin Wauplin merged commit d31c68d into huggingface:main Dec 4, 2025
18 of 19 checks passed
@krrome
Copy link
Contributor Author

krrome commented Dec 4, 2025

Thank you so much for your incredibly fast response time!

@krrome krrome deleted the fix/use-timeout-env-var-for-get_hf_file_metadata branch December 4, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_hf_file_metadata ignores HF_HUB_DOWNLOAD_TIMEOUT

3 participants