Skip to content

Missing Windows knobs to make it compatible with kernels #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfuntowicz merged 4 commits into from
Oct 24, 2025
Merged

Missing Windows knobs to make it compatible with kernels #277

mfuntowicz merged 4 commits into from
Oct 24, 2025

Conversation

@mfuntowicz
Copy link
Member

@mfuntowicz mfuntowicz commented Oct 23, 2025

  • Make sure the platform template variable is provided through build2cmake
  • Ensure correct install target is being called
  • Use "common" cmake ordering to invoke install target

MekkCyber
MekkCyber approved these changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@mfuntowicz mfuntowicz merged commit 9855e2c into main Oct 24, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MekkCyber MekkCyber MekkCyber approved these changes

@danieldk danieldk Awaiting requested review from danieldk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfuntowicz @MekkCyber