Let build2cmake generate metadata.json
#328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
build2cmake-dep-metadata
branch
from
eb0b277 to
884ff6a
Compare
mfuntowicz
approved these changes
Dec 17, 2025
Member
mfuntowicz
left a comment
mfuntowicz
left a comment
There was a problem hiding this comment.
LGTM, thanks for making it available for Windows too.
Is there already an example kernel leveraging this somewhere I can give it a quick try on a Windows machine?
Member
Author
I think this would be very useful to test with https://github.com/huggingface/kernels-community/tree/main/rmsnorm with this added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were generating it from Nix first, but then we need the same logic on the Windows side. So, instead, let
build2cmakegenerate file and let the Nix/Windows builders put it in place.