Validate kernel Python dependencies #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danieldk
force-pushed
the
validate-dependencies
branch
from
31d86e0 to
41c9f9c
Compare
MekkCyber
previously approved these changes
Nov 18, 2025
Comment on lines
+10
to
+14
| if must_raise: | ||
| with pytest.raises( | ||
| ImportError, match=r"Kernel requires dependency `nvidia-cutlass-dsl`" | ||
| ): | ||
| get_kernel("kernels-test/python-dep") |
Collaborator
There was a problem hiding this comment.
an other nit : this path will not be tested since we installed nvidia-cutlass-dsl in the runner before running tests
Member
Author
There was a problem hiding this comment.
We run tests twice, once without nvidia-cutlass-dsl and once with.
Collaborator
There was a problem hiding this comment.
ah sorry yes didn't see that
MekkCyber
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.