Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This function lists all the variants that are available on the current system.
danieldk
force-pushed
the
system-variants
branch
from
c53cde0 to
b8a27cb
Compare
danieldk
commented
Apr 1, 2026
sayakpaul
previously approved these changes
Apr 1, 2026
Comment on lines
+204
to
+212
| def possible_variants() -> list["ArchVariant"]: | ||
| frameworks: list[Torch | TvmFfi] = ( | ||
| Torch.possible_variants() + TvmFfi.possible_variants() | ||
| ) | ||
| archs = Arch.possible_variants() | ||
| return [ | ||
| ArchVariant(framework=fw, arch=arch) | ||
| for fw, arch in itertools.product(frameworks, archs) | ||
| ] |
Member
There was a problem hiding this comment.
This is so neat! As declarative as it gets.
sayakpaul
reviewed
Apr 3, 2026
| system_variants, | ||
| ) | ||
|
|
||
| VARIANT_STRINGS = ( |
sayakpaul
approved these changes
Apr 3, 2026
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks a lot for iterating on this and being patient with my suggestions on variant parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function lists all the variants that are available on the current system.