Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danieldk
reviewed
Apr 15, 2026
Member
danieldk
left a comment
danieldk
left a comment
There was a problem hiding this comment.
Looks great! Added a bunch of comments.
danieldk
approved these changes
Apr 15, 2026
Member
danieldk
left a comment
danieldk
left a comment
There was a problem hiding this comment.
Looks great, added one minor nit, feel free to implement or ignore.
| "https://raw.githubusercontent.com/huggingface/kernels/main/kernel-builder/skills"; | ||
|
|
||
| #[derive(Clone, Debug, Default, ValueEnum)] | ||
| pub enum SkillId { |
Member
There was a problem hiding this comment.
Minor nit: just Skill seems like a better name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442
Main change:
kernels/src/kernels/cli/skills.py->kernel-builder/scripts/install_skills.py(standalone script with its own argparse)Otherwise, we'd need a CLI implemented in Rust. I think that would be overkill for now, for something that's experimental?
The new usage is
python kernel-builder/scripts/install_skills.py --claude.