kernel-builder: detect card in result, build, or target dir#464
Merged
kernel-builder: detect card in result, build, or target dir#464
result, build, or target dir#464Conversation
Before this change, the card would only be detected in the `build` directory. However, we often only have a `result` directory or specify the build directory directly.
sayakpaul
previously approved these changes
Apr 16, 2026
| let filename = filename.as_ref(); | ||
|
|
||
| let candidates = [ | ||
| kernel_dir.join("result").join(filename), |
Member
There was a problem hiding this comment.
But is it a valid build in case we don't have the build dir and hence, no point doing the system card?
Member
Author
There was a problem hiding this comment.
Yes, normally when we do kernel-builder build, we only have the result symlink. build only gets created with kernel-builder build-and-copy.
| let found = discover_build_file(kernel_dir, "CARD.md").unwrap(); | ||
| assert_eq!(found, target); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Should there be a test where a target dir is explicitly specified?
Member
Author
There was a problem hiding this comment.
That's actually this one, the test name does not clearly communicate that, let me update the name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the card would only be detected in the
builddirectory. However, we often only have aresultdirectory or specify the build directory directly.