Skip to content

kernel-builder: fix failed uploads trying to remove directories#516

Merged
danieldk merged 1 commit intomainfrom
fix-upload-failure
May 4, 2026
Merged

kernel-builder: fix failed uploads trying to remove directories#516
danieldk merged 1 commit intomainfrom
fix-upload-failure

Conversation

@danieldk
Copy link
Copy Markdown
Member

@danieldk danieldk commented May 4, 2026

When trying to collect candidates for stale entries, we included directories as well. This causes upload failures, since directories are not Git objects and the API would reject these.

When trying to collect candidates for stale entries, we included
directories as well. This causes upload failures, since directories
are not Git objects and the API would reject these.
Copy link
Copy Markdown
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

this issue was introduced when moving to the hf hub library in #511 (specifically the api change from list_files to list_tree resulted in dirs being included in the list)

@danieldk danieldk merged commit b2358ea into main May 4, 2026
68 of 69 checks passed
@danieldk danieldk deleted the fix-upload-failure branch May 4, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants