nix-builder: add a hook to detect incorrect op registrations#569
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
May 19, 2026
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks. Just some nits.
But I don't see examples/kernels/silu-and-mul-bad-registration being used anywhere. Did we mean to include some checks against it in the CI?
| @@ -0,0 +1,12 @@ | |||
| import torch | |||
Member
There was a problem hiding this comment.
Very very good idea to include an example to test bad registration sites!
| import sys | ||
| from pathlib import Path | ||
|
|
||
| TORCH_LIBRARY_DECORATORS = frozenset( |
Member
There was a problem hiding this comment.
For now, this is fine (as you also mentioned internally).
Member
Author
|
danieldk
commented
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update the documentation to mention that ops should be prefixed with the correct name.