-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add RLBench #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add RLBench #290
Conversation
…ib doesn't work with AsyncEnv
lerobot/configs/policy/act.yaml
Outdated
|
|
||
| override_dataset_stats: | ||
| observation.images.top: | ||
| observation.images.wrist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose you plan to revert all of the changes in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure how to deal with the config for rlbench. For now, I have added a separate config file.
|
|
||
| env: | ||
| name: aloha | ||
| name: gym_aloha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main reason is removing this line:
https://github.com/huggingface/lerobot/pull/290/files/e7d4901301a35e18dcfcf6e4f04b68f84d2a929a#diff-0f7c1a6977da530f85035451866c98b1938bee512d68bfd4febfb1a8e367114eL30
Previously, there was an assumption that all package names of the environments were prefixed by gym_. In rlbench, this is not the case. I could either keep this assumption and have a special case for rlbench, or remove the assumption. I thought the latter was better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eugeneteoh, this is about what I had in mind for supporting multiple "state" vectors. I've reviewed the modeling code and will leave the dataset stuff to @Cadene
| self.use_input_state = "observation.state" in config.input_shapes | ||
|
|
||
| # If any keys with the prefix "observation.state" are present in the input_shapes, we will use the use state information | ||
| expected_state_keys = [k for k in config.input_shapes if k.startswith("observation.state")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah so as I was mentioning before. Don't you already have this set up as an instance attribute at this point?
|
Hi, when will this feature be merged? Are there any ways to run act on rlbench? |
|
This PR has been automatically marked as stale because it has not had recent activity (6 months). It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi what about the recent update in this PR? I wonder ask will this feature be merged into lerobot recently? :) |
What this does
Add RLBench as a benchmark.
https://github.com/stepjam/RLBench
How it was tested
How to checkout & try? (for the reviewer)