Fix #66 #67
Merged
Fix #66 #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the chat templates since correct mechanism is in
|
Can confirm it works well |
|
I've tested it as well and confirm it works - shall we merge? |
|
Not merging without maintainer approval :) (in this case, @NathanHB , who's off on Tuesdays ^^) |
NathanHB
approved these changes
Feb 27, 2024
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
We actually don't need to use the tokenizer.apply_chat_template for the possible choices, since the correct logic is taken care of in get_examples_with_chat_template, which adds a generation prompt start before the tokens
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
We actually don't need to use the tokenizer.apply_chat_template for the possible choices, since the correct logic is taken care of in get_examples_with_chat_template, which adds a generation prompt start before the tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #66
We actually don't need to use the tokenizer.apply_chat_template for the possible choices, since the correct logic is taken care of in
get_examples_with_chat_template, which adds a generation prompt start before the tokens