feat(config): accept to run llm-ls in PATH#116
Merged
McPatate merged 3 commits intohuggingface:mainfrom Jan 9, 2025
Merged
Conversation
It's uncommon to completely ignore PATH. I have llm-ls installed via my package manager, and the downloaded one wouldn't work anyway. If bin_path is not set, llm.nvim will try to start llm-ls from PATH, else fallback to config.lsp.bin_path. Note that we dont check The 'version' of llm-ls so it's possible for the plugin to run a version that doesn't match the one configured (for instance if you've added it after the first run of llm.nvim). A version check could/should be added later.
McPatate
reviewed
Jan 8, 2025
Member
McPatate
left a comment
McPatate
left a comment
There was a problem hiding this comment.
Other than the small nit, lgtm!
| return | ||
| end | ||
|
|
||
| local cmd |
Member
There was a problem hiding this comment.
I'd leave this here and put cmd = { bin_path } in an else clause after line 200, for reading consistency.
Contributor
Author
There was a problem hiding this comment.
ty for review. I've pushed a fixup tested locally. If it's good I can squash or you can do it from github UI.
McPatate
reviewed
Jan 9, 2025
McPatate
approved these changes
Jan 9, 2025
Member
McPatate
left a comment
McPatate
left a comment
There was a problem hiding this comment.
Thanks again for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's uncommon to completely ignore PATH. I have llm-ls installed via my package manager, and the downloaded one wouldn't work anyway. If bin_path is not set, llm.nvim will try to start llm-ls from PATH, else fallback to config.lsp.bin_path. Note that we dont check The 'version' of llm-ls so it's possible for the plugin to run a version that doesn't match the one configured (for instance if you've added it after the first run of llm.nvim). A version check could/should be added later.