Fix HabanaGenerationTime usage in tests #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For two test cases: `test_feature_extraction` and `test_video_mae` the line that accessed the measured time was still within the scope of the context manager, so that `last_duration` was still set to `None`. This commit fixes the indentation of those lines.
Collaborator
Author
|
Needs to be also cherrypicked to |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
pushed a commit
that referenced
this pull request
Jun 25, 2025
For two test cases: `test_feature_extraction` and `test_video_mae` the line that accessed the measured time was still within the scope of the context manager, so that `last_duration` was still set to `None`. This commit fixes the indentation of those lines.
Collaborator
Done |
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 3, 2025
For two test cases: `test_feature_extraction` and `test_video_mae` the line that accessed the measured time was still within the scope of the context manager, so that `last_duration` was still set to `None`. This commit fixes the indentation of those lines.
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 3, 2025
For two test cases: `test_feature_extraction` and `test_video_mae` the line that accessed the measured time was still within the scope of the context manager, so that `last_duration` was still set to `None`. This commit fixes the indentation of those lines.
astachowiczhabana
added a commit
that referenced
this pull request
Jul 4, 2025
* Add additional info about attn batch split flag (#1990) * Add SD3 fine-tuning scripts (#1966) Signed-off-by: Daniel Socek <daniel.socek@intel.com> Co-authored-by: Deepak Gowda Doddbele Aswatha Narayana <deepak.narayana@intel.com> Co-authored-by: Pavel Evsikov <pavel.evsikov@intel.com> Co-authored-by: regisss <15324346+regisss@users.noreply.github.com> * Migrate tests to upstream repos (#2002) remove * Fix makefile commands (#2025) * fix makefile commands not ran correctly * fix 1x slow tests command * Add token to single card tests CI (#2034) add token to single card tests * Minor Code Comments and Formatting Improvements (#2035) * Remove text-generation-inference folder (#2068) * fea(): updated the readme for mediapipe support (#2012) * Update CI and docs for SynapseAI 1.21 (#2060) * Use makefile in Sentence Transformers CI (#2073) * use makefile * add st command * Add missing test dependencies for image-to-text (#2061) - add `tiktoken` and `blobfile` to `TEST_REQUIRE` in `setup.py` - cleanup `test_image_to_text_example.py` * Fix HabanaGenerationTime usage in tests (#2064) For two test cases: `test_feature_extraction` and `test_video_mae` the line that accessed the measured time was still within the scope of the context manager, so that `last_duration` was still set to `None`. This commit fixes the indentation of those lines. * Minor Documentation Updates and Comments Clarification (#2048) * Use `PT_ENABLE_INT64_SUPPORT=1` for trl examples (#2089) --------- Signed-off-by: Daniel Socek <daniel.socek@intel.com> Co-authored-by: Jay Gala <jaygala@habana.ai> Co-authored-by: Daniel Socek <daniel.socek@intel.com> Co-authored-by: Deepak Gowda Doddbele Aswatha Narayana <deepak.narayana@intel.com> Co-authored-by: Pavel Evsikov <pavel.evsikov@intel.com> Co-authored-by: regisss <15324346+regisss@users.noreply.github.com> Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com> Co-authored-by: leopardracer <136604165+leopardracer@users.noreply.github.com> Co-authored-by: Iman Gohari <s.m.iman.gohari@intel.com> Co-authored-by: Piotr Bielak <pbielak@users.noreply.github.com> Co-authored-by: kilavvy <140459108+kilavvy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For two test cases:
test_feature_extractionandtest_video_maethe line that accessed the measured time (HabanaGenerationTime) was still within the scope of the context manager, so thatlast_durationwas still set toNone. This commit fixes the indentation of those lines.