Merged
Conversation
Contributor
Author
|
@michaelbenayoun Would you mind taking a look? |
tests/test_generate.py
Outdated
| @is_trainium_test | ||
| @pytest.mark.parametrize("model_name, use_cache, decoder_only", beam_search_testdata) | ||
| def test_beam_search_decoding(model_name, use_cache, decoder_only): | ||
| os.environ['NEURON_CC_FLAGS'] = '--model-type=transformer --enable-saturate-infinity' |
Member
There was a problem hiding this comment.
If we need that, we should add this to the generate method no?
Contributor
Author
There was a problem hiding this comment.
It is actually specific to the BART model.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Member
|
You can fix the styling issue by running: |
michaelbenayoun
approved these changes
Jun 12, 2023
Contributor
Author
|
@michaelbenayoun is there anything on my end that I can do to make the tests pass? |
Member
|
No, I think this is ok, you would need to be a collaborator to be able to run the CI. |
1 similar comment
Member
|
No, I think this is ok, you would need to be a collaborator to be able to run the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added beam search functionality with a test for bart-base model. Currently, KV cache does not work which is likely due to BART-specific preparation of decoder mask.