allow string device input for OrtModel.to(device)#337
Merged
regisss merged 4 commits intohuggingface:mainfrom Aug 8, 2022
Merged
allow string device input for OrtModel.to(device)#337regisss merged 4 commits intohuggingface:mainfrom
regisss merged 4 commits intohuggingface:mainfrom
Conversation
regisss
approved these changes
Aug 8, 2022
Contributor
regisss
left a comment
regisss
left a comment
There was a problem hiding this comment.
Thanks for adding this @jessecambon!!
Contributor
|
@jessecambon You need to rebase your branch on the main branch so that the tests pass |
|
The documentation is not available anymore as the PR was closed or merged. |
jessecambon
force-pushed
the
string-device-input
branch
from
133377b to
8c33e0f
Compare
Contributor
Author
|
@regisss thanks, I also added the same modification to the sequence to sequence model and added tests. My fork should now be up-to-date with main. |
Contributor
Thanks a lot @jessecambon 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements #336