FIX Issue with disable adapter test#3045
Merged
BenjaminBossan merged 1 commit intohuggingface:mainfrom Feb 17, 2026
Merged
Conversation
In huggingface#3031, a fix to one of the custom models (using embedding + Conv1D) was introduced to resolve an error in the test_disable_adapters test when run on GPU. However, this very fix resulted in the test failing in some settings on CPU. This PR makes specific changes for CPU to avoid these failures. With this PR, the mentioned tests pass locally both on CPU and GPU. Note, however, that other tests involving this custom model still fail on GPU, irrespective of the changes in huggingface#3031. Fixing these tests would probably require carefully choosing the right tolerances used in the tests, with little to no benefit for actual PEFT use. Therefore, I consider it low priority to investigate these tests.
githubnemo
approved these changes
Feb 17, 2026
Collaborator
githubnemo
left a comment
githubnemo
left a comment
There was a problem hiding this comment.
I'm hopeful that someday in the future we are enlightened why this is happening the way it is. Today is not the day and this change is good :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3031, a fix to one of the custom models (using embedding + Conv1D) was introduced to resolve an error in the
test_disable_adapterstest when run on GPU. However, this very fix resulted in the test failing in some settings on CPU. This PR makes specific changes for CPU to avoid these failures.With this PR, the mentioned tests pass locally both on CPU and GPU. Note, however, that other tests involving this custom model still fail on GPU, irrespective of the changes in #3031. Fixing these tests would probably require carefully choosing the right tolerances used in the tests, with little to no benefit for actual PEFT use. Therefore, I consider it low priority to investigate these tests.