Skip to content

Conversation

@pcuenca
Copy link
Member

@pcuenca pcuenca commented Sep 25, 2025

No description provided.

@mattt
Copy link
Collaborator

mattt commented Sep 25, 2025

@pcuenca I'm fighting CI in #240, too. I'm not sure what changed from under our feet to cause lint to start failing. It's frustrating that the pull_request_target is causing the workflow in main to be run instead of the updated one here. Not sure what the right fix is there. (YOLO?)

@pcuenca
Copy link
Member Author

pcuenca commented Sep 25, 2025

Yes, I'm seeing these problems since yesterday night. In addition, swift format was apparently randomly failing to update my files locally for some reason (might be user error).

I think we only need pull_request_target for the external workflow, but for now we can merge this or #240 and verify.

@mattt
Copy link
Collaborator

mattt commented Sep 25, 2025

Extremely spooky that nothing seems to have changed in CI runner or our workflow, but we started getting failures...

Last succeeded: https://github.com/huggingface/swift-transformers/actions/runs/17984247022/job/51158207015
First failed: https://github.com/huggingface/swift-transformers/actions/runs/18005981937/job/51226463719?pr=262

Both have identical output for initial setup job step:

Screenshot 2025-09-25 at 04 36 02

@mattt
Copy link
Collaborator

mattt commented Sep 25, 2025

I think we only need pull_request_target for the external workflow, but for now we can merge this or #240 and verify.

Let's go ahead and merge this, since it's a more targeted change, and then I'll try again on #240

@pcuenca pcuenca merged commit f234387 into main Sep 25, 2025
0 of 4 checks passed
@pcuenca pcuenca deleted the lint branch September 25, 2025 11:38
@mattt
Copy link
Collaborator

mattt commented Sep 25, 2025

@pcuenca 🙃 ✅ https://github.com/huggingface/swift-transformers/actions/runs/18006286755/job/51227165617?pr=240

@pcuenca
Copy link
Member Author

pcuenca commented Sep 25, 2025

I'll wait for #240 and then I'll do #261 and #257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants