Fix reading non-standard config for past_key_values in ONNX
#751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes how the
config.jsonis read for e.g.nomic-ai/nomic-embed-text-v1doesn't use the standard naming for thehidden_size,num_hidden_layers, andnum_key_value_heads, but rathern_embd,n_layer, andn_head, respectively.Note
Note that this is required given that the ONNX export for e.g.
nomic-ai/nomic-embed-text-v1is using optimized MHA/MQA nodes, hence the need for the reading theconfig.jsonto properly parse thepast_key_valuesweights on the ONNX export.Fixes #750
Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.