-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Description
Overview:
When building the FBGEMM project using the provided makefile, the current implementation attempts to clone the fbgemm repository every time the build command is executed. If the fbgemm directory already exists (from a previous build attempt), the cloning step fails with an error, disrupting the build process.
Problem:
text-generation-inference/server/Makefile-fbgemm
Lines 3 to 4 in 6cb42f4
| build-fbgemm: | |
| git clone https://github.com/pytorch/FBGEMM.git fbgemm && \ |
- The makefile does not currently check for the existence of the
fbgemmdirectory before attempting to clone the repository. - If the build process is interrupted or fails after the repository is cloned, any subsequent build attempt will encounter an error due to the existing
fbgemmdirectory.
Proposed Solution:
- Modify the makefile to include a directory check before cloning the repository. If the
fbgemmdirectory already exists, the script should skip the cloning step and proceed with the remaining build steps.
Metadata
Metadata
Assignees
Labels
No labels