Skip to content

Directory check missing in FBGEMM Makefile #2485

@vamsivallepu

Description

@vamsivallepu

Overview:

When building the FBGEMM project using the provided makefile, the current implementation attempts to clone the fbgemm repository every time the build command is executed. If the fbgemm directory already exists (from a previous build attempt), the cloning step fails with an error, disrupting the build process.

Problem:

build-fbgemm:
git clone https://github.com/pytorch/FBGEMM.git fbgemm && \

  • The makefile does not currently check for the existence of the fbgemm directory before attempting to clone the repository.
  • If the build process is interrupted or fails after the repository is cloned, any subsequent build attempt will encounter an error due to the existing fbgemm directory.

Proposed Solution:

  • Modify the makefile to include a directory check before cloning the repository. If the fbgemm directory already exists, the script should skip the cloning step and proceed with the remaining build steps.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions