Skip to content

Conversation

@vamsivallepu
Copy link
Contributor

@vamsivallepu vamsivallepu commented Sep 4, 2024

What does this PR do?

Fixes #2485

This PR adds a check to the build process that prevents the fbgemm repository from being cloned if the directory already exists, avoiding potential errors when re-running the build.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed.
@OlivierDehaene @Narsil

Added Directory check for FBGEMM repository cloning.
@ErikKaum
Copy link
Member

ErikKaum commented Sep 5, 2024

Hi @vamsivallepu

Thanks for the PR 🙌
I think this should be good to go. Let me first double check 👍

@vamsivallepu
Copy link
Contributor Author

@ErikKaum Can we merge this?

@ErikKaum
Copy link
Member

ErikKaum commented Sep 6, 2024

Ah thanks for reminding me, I've created a branch to run the CI so that it doesn't fail in permissions 👍

@ErikKaum ErikKaum merged commit eabbbbd into huggingface:main Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directory check missing in FBGEMM Makefile

2 participants