feat: Add weakref support to Tokenizer class#1958
Merged
ArthurZucker merged 3 commits intohuggingface:mainfrom Mar 25, 2026
Merged
feat: Add weakref support to Tokenizer class#1958ArthurZucker merged 3 commits intohuggingface:mainfrom
ArthurZucker merged 3 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
can you run fmt + clippy!? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
tokenizers.Tokenizerclass currently does not support Python weak references, which prevents its use with frameworks that rely onweakreffor resource management.Error without this change:
Use cases that benefit:
Solution
Add weakref parameter to the #[pyclass] macro in PyO3 bindings.