Skip to content

feat: add support for uv in Makefile#1977

Merged
McPatate merged 3 commits intomainfrom
feat/support_uv_in_makefile
Mar 25, 2026
Merged

feat: add support for uv in Makefile#1977
McPatate merged 3 commits intomainfrom
feat/support_uv_in_makefile

Conversation

@McPatate
Copy link
Copy Markdown
Member

auto-detect uv in Makefile and set correct env vars for cargo test to work (issue with uv broken dylib install names, cf astral-sh/uv#11006)

@McPatate McPatate requested a review from ArthurZucker March 24, 2026 16:34
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md

```bash
cd bindings/python
pip install -e ".[dev]" # install in editable mode with test deps (builds via maturin)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Comment thread CONTRIBUTING.md
Comment on lines +100 to +103
```bash
export DYLD_FALLBACK_LIBRARY_PATH="$(python3 -c 'import sysconfig; print(sysconfig.get_config_var("LIBDIR"))')"
export PYTHONHOME="$(python3 -c 'import sys; print(sys.base_prefix)')"
cargo test --no-default-features
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added CARGO_ENV to the cargo run in the make style rule ✅

@McPatate McPatate merged commit 9d89977 into main Mar 25, 2026
31 of 35 checks passed
@McPatate McPatate deleted the feat/support_uv_in_makefile branch March 25, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants