-
Notifications
You must be signed in to change notification settings - Fork 31.2k
Resnet #15770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resnet #15770
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
7360d5d to
13bc1e2
Compare
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this model! It's very clean already, I just have one naming suggestion.
Make sure that the conversion script can work for someone who is not yourself and I think we could expand it to work for more checkpoints?
13bc1e2 to
3e382a4
Compare
|
I've removed the |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regression part should be added back. There are problems that can be framed as regression from images (guessing some coordinates inside the image, the age of a subject in a picture, the angle at which a picture was taken etc.).
|
I've removed the |
src/transformers/modeling_outputs.py
Outdated
|
|
||
|
|
||
| @dataclass | ||
| class BaseModelOutputWithNoAttentionAndWithPooling(ModelOutput): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a horrible name.. but ok i guess, since BaseModelOutputWithPooling is already taken? cc @sgugger @LysandreJik
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
06f544c to
8708d65
Compare
NielsRogge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This WIP PR adds ResNet.
Currently, the model can be used as follows