Use tiny models for get_pretrained_model in TFEncoderDecoderModelTest #15989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
changed the title
LysandreJik
approved these changes
Mar 9, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Looks good to me, thank you @ydshieh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use tiny models for
get_pretrained_modelinTFEncoderDecoderModelTest.This is originally for avoiding GPU OOM for
TFRembertEncoderDecoderModelTeston CI daily testing.But @patrickvonplaten suggests that we should actually use the small model in the following quote:
... think we can rename it to test_model_save_loaf_from_pretrained(...) 😉 I think this "real" name was propragated since the first encoder-decoder tests existed in PyTorch. Since the test does no integration testing (e.g. checking if the output corresponds to something reasonable) it makes 0 difference whether we use dummy weights or no dummy weights here ...