Skip to content

Choose framework for ONNX export #16018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2022
Merged

Choose framework for ONNX export #16018

merged 2 commits into from
Mar 14, 2022

Conversation

@michaelbenayoun
Copy link
Member

@michaelbenayoun michaelbenayoun commented Mar 9, 2022

What does this PR do?

This allows to choose which framework to use between PyTorch and TensorFlow for the ONNX export.

Fixes #15990

@michaelbenayoun michaelbenayoun requested a review from lewtun March 9, 2022 15:02
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 9, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@michaelbenayoun michaelbenayoun requested a review from sgugger March 9, 2022 15:15
lewtun
lewtun reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @michaelbenayoun - the change looks great! I left some nits about docstrings and a question about running in a pure tensorflow env.

src/transformers/onnx/features.py Outdated
Copy link
Member

@lewtun lewtun Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens here if only tensorflow is installed?

If I understand correctly, since _TASKS_TO_AUTOMODELS is an empty dict by default here, this error won't show the possible values for a pure tensorflow env because we should be accessing _TASKS_TO_TF_AUTOMODELS in that case

Copy link
Member Author

@michaelbenayoun michaelbenayoun Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I added a method called _validate_framework_choice that should take care of that.

Copy link
Member

@lewtun lewtun Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

sgugger
sgugger approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lewtun
lewtun approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this - LGTM!

src/transformers/onnx/features.py Outdated
Copy link
Member

@lewtun lewtun Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelbenayoun michaelbenayoun merged commit 37a9fc4 into huggingface:master Mar 14, 2022
@michaelbenayoun michaelbenayoun deleted the onnx_framework_choice branch March 14, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewtun lewtun lewtun approved these changes

+1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FeaturesManager assumes only one of Torch or TensorFlow is installed

4 participants

@michaelbenayoun @HuggingFaceDocBuilderDev @lewtun @sgugger